OLH-3176 - Switch to using AWS SAM to building Lambdas#2559
Open
peterfajemisincabinetoffice wants to merge 5 commits intomainfrom
Open
OLH-3176 - Switch to using AWS SAM to building Lambdas#2559peterfajemisincabinetoffice wants to merge 5 commits intomainfrom
peterfajemisincabinetoffice wants to merge 5 commits intomainfrom
Conversation
peterfajemisincabinetoffice
force-pushed
the
OLH-3176
branch
2 times, most recently
from
6ea349e to
52d9f46
Compare
peterfajemisincabinetoffice
force-pushed
the
OLH-3176
branch
2 times, most recently
from
5e3d390 to
23c668c
Compare
peterfajemisincabinetoffice
force-pushed
the
OLH-3176
branch
from
23c668c to
14b6308
Compare
OLH-3176 Switch to using AWS SAM to building Lambdas OLH-3177 Fix package import of new aws sdk affecting tests OLH-3411 Move RequestBasedScaling into separate template.yml as a sidecar to frontend stack
peterfajemisincabinetoffice
force-pushed
the
OLH-3176
branch
from
6054775 to
7ca75ec
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
OLH-3176 - Switch to using AWS SAM to building Lambdas
OLH-3411 - Move RequestBasedScaling into separate template.yml as a nested to frontend stack
What changed
OLH-3176 - Switch to using AWS SAM to building Lambdas
OLH-3411 - Move RequestBasedScaling into separate template.yml as a nested to frontend stack
Why did it change
So that request based scaling can be deployed with separation of concern as an applied methodology.
Related links
Combines work done in multiple PRs
#2553
Also covers work done for multiple JIRA tickets
https://govukverify.atlassian.net/browse/OLH-3411
https://govukverify.atlassian.net/browse/OLH-3177
https://govukverify.atlassian.net/browse/OLH-3176
https://govukverify.atlassian.net/browse/OLH-3175
Checklists
Environment variables or secrets
New secrets added in github
Testing
Ensure successful deployment in dev environment
Check with a running performance test and watch scaling happen
Ensure there is a rollback strategy
Deploy to non dev and non prod environment and ensure succesfully deployed with no issues
Test rollback in non prod and non dev environment
Sign-offs
Monitoring
How to review